jannik/fuelstats
1
0
Fork 0
Code Issues 12 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Brand Normalizer #17

Open
j0code wants to merge 4 commits from feature/brand_normalizer into main
pull from: feature/brand_normalizer
merge into: jannik:main
Conversation 1 Commits 4 Files changed 11 +717
j0code commented 2026-05-28 18:04:44 +02:00
Collaborator
Copy link

Adds the brand normalizer to the repo.

You might notice, I renamed the "unknown", "OTHER", and "CLOSED" to "$$unknown$$", "$$other$$", and "$$closed$$".
This is for consistency and so they can be more easily be detected and replaced with something like "(unknown)" or "unknown brand" or whatever.

Adds the brand normalizer to the repo. You might notice, I renamed the "unknown", "OTHER", and "CLOSED" to "$$unknown$$", "$$other$$", and "$$closed$$". This is for consistency and so they can be more easily be detected and replaced with something like "(unknown)" or "unknown brand" or whatever.
j0code self-assigned this 2026-05-28 18:04:44 +02:00
j0code scheduled this pull request to auto merge when all checks succeed 2026-05-28 18:06:19 +02:00
j0code requested review from jannik 2026-05-28 18:06:59 +02:00
jannik requested changes 2026-05-28 18:39:29 +02:00
jannik left a comment
Copy link

Rest looks pretty good on first look

Rest looks pretty good on first look
normalizer/config.example.json Outdated
@ -0,0 +3,4 @@
"username": "INSERT USERNAME HERE",
"password": "INSERT PASSWORD HERE",
"host": "example.com",
"path": "/"
jannik commented 2026-05-28 18:33:46 +02:00
Owner
Copy link
-		"path": "/"
+		"database": "fuel"
```diff - "path": "/" + "database": "fuel" ```
j0code commented 2026-05-28 18:45:23 +02:00
Author
Collaborator
Copy link

done in 7996b090c4

done in https://git.picoscratch.de/jannik/fuelstats/commit/7996b090c4aa29a6c2735436b9709cd124bc6d6e
jannik marked this conversation as resolved
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/brand_normalizer:feature/brand_normalizer
git switch feature/brand_normalizer
Sign in to join this conversation.
Reviewers
No reviewers
jannik
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
j0code
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jannik/fuelstats!17
No description provided.