Prefer OSM translations to wikidata (#55)

This commit is contained in:
Michael Barry
2022-12-03 07:18:32 -05:00
committed by GitHub
parent 7171538bd5
commit e33b2bd2fe
7 changed files with 28 additions and 83 deletions

View File

@@ -15,7 +15,7 @@ class OpenMapTilesProfileTest {
private final Wikidata.WikidataTranslations wikidataTranslations = new Wikidata.WikidataTranslations();
private final Translations translations = Translations.defaultProvider(List.of("en", "es", "de"))
.addTranslationProvider(wikidataTranslations);
.addFallbackTranslationProvider(wikidataTranslations);
private final OpenMapTilesProfile profile = new OpenMapTilesProfile(translations, PlanetilerConfig.defaults(),
Stats.inMemory());

View File

@@ -33,7 +33,7 @@ public abstract class AbstractLayerTest {
final Wikidata.WikidataTranslations wikidataTranslations = new Wikidata.WikidataTranslations();
final Translations translations = Translations.defaultProvider(List.of("en", "es", "de"))
.addTranslationProvider(wikidataTranslations);
.addFallbackTranslationProvider(wikidataTranslations);
final PlanetilerConfig params = PlanetilerConfig.defaults();
final OpenMapTilesProfile profile = new OpenMapTilesProfile(translations, PlanetilerConfig.defaults(),

View File

@@ -25,7 +25,7 @@ class PlaceTest extends AbstractLayerTest {
"class", "continent",
"name", "North America",
"name:en", "North America",
"name:es", "América del Norte y América Central",
"name:es", "América del Norte",
"name:latin", "North America",
"rank", 1,
@@ -60,7 +60,7 @@ class PlaceTest extends AbstractLayerTest {
"class", "country",
"name", "United States of America",
"name_en", "United States of America",
"name:es", "Estados Unidos",
"name:es", "Estados Unidos de América",
"name:latin", "United States of America",
"iso_a2", "US",
"rank", 6,
@@ -86,7 +86,7 @@ class PlaceTest extends AbstractLayerTest {
"class", "country",
"name", "United States of America",
"name_en", "United States of America",
"name:es", "Estados Unidos",
"name:es", "Estados Unidos de América",
"name:latin", "United States of America",
"iso_a2", "US",
"rank", 1,

View File

@@ -19,7 +19,7 @@ class OmtLanguageUtilsTest {
private final Wikidata.WikidataTranslations wikidataTranslations = new Wikidata.WikidataTranslations();
private final Translations translations = Translations.defaultProvider(List.of("en", "es", "de"))
.addTranslationProvider(wikidataTranslations);
.addFallbackTranslationProvider(wikidataTranslations);
@Test
void testSimpleExample() {
@@ -227,15 +227,15 @@ class OmtLanguageUtilsTest {
}
@Test
void testPreferWikidata() {
void testPreferOsm() {
wikidataTranslations.put(123, "es", "wd es name");
wikidataTranslations.put(123, "de", "wd de name");
assertSubmap(Map.of(
"name:es", "wd es name",
"name:de", "de name osm"
), OmtLanguageUtils.getNames(Map.of(
"name", "name",
"wikidata", "Q123",
"name:es", "es name osm",
"name:de", "de name osm"
), translations));
}