diff --git a/src/main/java/com/onthegomap/planetiler/basemap/layers/MountainPeak.java b/src/main/java/com/onthegomap/planetiler/basemap/layers/MountainPeak.java index 46f9340..e8b0671 100644 --- a/src/main/java/com/onthegomap/planetiler/basemap/layers/MountainPeak.java +++ b/src/main/java/com/onthegomap/planetiler/basemap/layers/MountainPeak.java @@ -113,14 +113,14 @@ public class MountainPeak implements @Override public void process(Tables.OsmPeakPoint element, FeatureCollector features) { - Integer meters = Parse.parseIntSubstring(element.ele()); + Double meters = Parse.meters(element.ele()); if (meters != null && Math.abs(meters) < 10_000) { var feature = features.point(LAYER_NAME) .setAttr(Fields.CLASS, element.source().getTag("natural")) .putAttrs(LanguageUtils.getNames(element.source().tags(), translations)) .putAttrs(elevationTags(meters)) .setSortKeyDescending( - meters + + meters.intValue() + (nullIfEmpty(element.wikipedia()) != null ? 10_000 : 0) + (nullIfEmpty(element.name()) != null ? 10_000 : 0) ) diff --git a/src/main/java/com/onthegomap/planetiler/basemap/util/Utils.java b/src/main/java/com/onthegomap/planetiler/basemap/util/Utils.java index 7c88695..1308155 100644 --- a/src/main/java/com/onthegomap/planetiler/basemap/util/Utils.java +++ b/src/main/java/com/onthegomap/planetiler/basemap/util/Utils.java @@ -49,9 +49,9 @@ public class Utils { } /** Returns a map with {@code ele} (meters) and {ele_ft} attributes from an elevation in meters. */ - public static Map elevationTags(int meters) { + public static Map elevationTags(double meters) { return Map.of( - "ele", meters, + "ele", (int) Math.round(meters), "ele_ft", (int) Math.round(meters * 3.2808399) ); } @@ -61,7 +61,7 @@ public class Utils { * meters} can be parsed as a valid number. */ public static Map elevationTags(String meters) { - Integer ele = Parse.parseIntSubstring(meters); + Double ele = Parse.meters(meters); return ele == null ? Map.of() : elevationTags(ele); } diff --git a/src/test/java/com/onthegomap/planetiler/basemap/layers/AerodromeLabelTest.java b/src/test/java/com/onthegomap/planetiler/basemap/layers/AerodromeLabelTest.java index 237b3f6..5de4811 100644 --- a/src/test/java/com/onthegomap/planetiler/basemap/layers/AerodromeLabelTest.java +++ b/src/test/java/com/onthegomap/planetiler/basemap/layers/AerodromeLabelTest.java @@ -37,6 +37,36 @@ class AerodromeLabelTest extends AbstractLayerTest { )))); } + @Test + void testElevationFeet() { + assertFeatures(14, List.of(Map.of( + "ele", 100, + "ele_ft", 328 + )), process(pointFeature(Map.of( + "aeroway", "aerodrome", + "name", "osm name", + "ele", "328'", + "aerodrome", "international", + "iata", "123", + "icao", "1234" + )))); + } + + @Test + void testElevationFeetInches() { + assertFeatures(14, List.of(Map.of( + "ele", 100, + "ele_ft", 328 + )), process(pointFeature(Map.of( + "aeroway", "aerodrome", + "name", "osm name", + "ele", "328' 1\"", + "aerodrome", "international", + "iata", "123", + "icao", "1234" + )))); + } + @Test void testInternational() { assertFeatures(14, List.of(Map.of( diff --git a/src/test/java/com/onthegomap/planetiler/basemap/layers/MountainPeakTest.java b/src/test/java/com/onthegomap/planetiler/basemap/layers/MountainPeakTest.java index 5c8f216..f121e78 100644 --- a/src/test/java/com/onthegomap/planetiler/basemap/layers/MountainPeakTest.java +++ b/src/test/java/com/onthegomap/planetiler/basemap/layers/MountainPeakTest.java @@ -75,6 +75,30 @@ class MountainPeakTest extends AbstractLayerTest { )))); } + @Test + void testElevationFeet() { + assertFeatures(14, List.of(Map.of( + "class", "volcano", + "ele", 30, + "ele_ft", 100 + )), process(pointFeature(Map.of( + "natural", "volcano", + "ele", "100'" + )))); + } + + @Test + void testElevationFeetInches() { + assertFeatures(14, List.of(Map.of( + "class", "volcano", + "ele", 31, + "ele_ft", 101 + )), process(pointFeature(Map.of( + "natural", "volcano", + "ele", "100' 11\"" + )))); + } + @Test void testSaddle() { assertFeatures(14, List.of(Map.of(