trafficcue/planetiler-openmaptiles
1
0
Fork 0
mirror of https://github.com/cfpwastaken/planetiler-openmaptiles.git synced 2026-02-04 12:31:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ambiguity in _Example adding an attribute to a built-in layer_ (#152)

Browse Source 
The current example adds the "source" attribute to the Building layer. Unfortunately, `source()` is also a name of a method used in the code. The method name should not be changed if a different attribute is needed. 

If a naive developer, who wants to add the "name" attribute,  replace all instances of `source` with `name`

```diff
@@ -166,6 +166,7 @@ public class Building implements
         .setAttrWithMinzoom(Fields.RENDER_MIN_HEIGHT, renderMinHeight, 14)
         .setAttrWithMinzoom(Fields.COLOUR, color, 14)
         .setAttrWithMinzoom(Fields.HIDE_3D, hide3d, 14)
+        .setAttrWithMinzoom("name", element.name().getTag("name"), 14)
         .setSortKey(renderHeight);
       if (mergeZ13Buildings) {
         feature
```

a compilation error is produced

```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] .../planetiler-openmaptiles/src/main/java/org/openmaptiles/layers/Building.java:[169,44] cannot find symbol
  symbol:   method name()
  location: variable element of type org.openmaptiles.generated.Tables.OsmBuildingPolygon
```

To clarify the matters, this PR adds the attribute "name" that differs from any method in the additional line.
This commit is contained in:
zstadler
2024-01-28 19:44:17 +02:00
committed by GitHub
parent 3c759b20fa
commit 4cd2eb1cb7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@@ -45,7 +45,7 @@ the [layers package](src/main/java/org/openmaptiles/layers), and make a change t
Example adding an attribute to a built-in layer Example adding an attribute to a built-in layer
</summary> </summary>
For example to copy over the source attribute from OpenStreetMap elements to the building layer, For example to copy over the name attribute from OpenStreetMap elements to the building layer,
modify [Building.java](src/main/java/org/openmaptiles/layers/Building.java): modify [Building.java](src/main/java/org/openmaptiles/layers/Building.java):
```diff ```diff
@@ -53,7 +53,7 @@ modify [Building.java](src/main/java/org/openmaptiles/layers/Building.java):
.setAttrWithMinzoom(Fields.RENDER_MIN_HEIGHT, renderMinHeight, 14) .setAttrWithMinzoom(Fields.RENDER_MIN_HEIGHT, renderMinHeight, 14)
.setAttrWithMinzoom(Fields.COLOUR, color, 14) .setAttrWithMinzoom(Fields.COLOUR, color, 14)
.setAttrWithMinzoom(Fields.HIDE_3D, hide3d, 14) .setAttrWithMinzoom(Fields.HIDE_3D, hide3d, 14)
+ .setAttrWithMinzoom("source", element.source().getTag("source"), 14) + .setAttrWithMinzoom("name", element.source().getTag("name"), 14)
.setSortKey(renderHeight); .setSortKey(renderHeight);
if (mergeZ13Buildings) { if (mergeZ13Buildings) {
feature feature