js: cleanup error throwing to always use new Error (#504)

js/src/index.ts

@@ -98,10 +98,10 @@ const tzValues: number[] = [
  */
 export function zxyToTileId(z: number, x: number, y: number): number {
   if (z > 26) {
-    throw Error("Tile zoom level exceeds max safe number limit (26)");
+    throw new Error("Tile zoom level exceeds max safe number limit (26)");
   }
   if (x > 2 ** z - 1 || y > 2 ** z - 1) {
-    throw Error("tile x/y outside zoom level bounds");
+    throw new Error("tile x/y outside zoom level bounds");
   }
 
   const acc = tzValues[z];
@@ -136,7 +136,7 @@ export function tileIdToZxy(i: number): [number, number, number] {
     acc += numTiles;
   }
 
-  throw Error("Tile zoom level exceeds max safe number limit (26)");
+  throw new Error("Tile zoom level exceeds max safe number limit (26)");
 }
 
 /**
@@ -196,7 +196,7 @@ async function defaultDecompress(
     }
     const stream = new Response(buf).body;
     if (!stream) {
-      throw Error("Failed to read response stream");
+      throw new Error("Failed to read response stream");
     }
     const result: ReadableStream<Uint8Array> = stream.pipeThrough(
       // biome-ignore lint: needed to detect DecompressionStream in browser+node+cloudflare workers
@@ -204,7 +204,7 @@ async function defaultDecompress(
     );
     return new Response(result).arrayBuffer();
   }
-  throw Error("Compression method not supported");
+  throw new Error("Compression method not supported");
 }
 
 /**
@@ -431,7 +431,7 @@ export class FetchSource implements Source {
     if (offset === 0 && resp.status === 416) {
       const contentRange = resp.headers.get("Content-Range");
       if (!contentRange || !contentRange.startsWith("bytes */")) {
-        throw Error("Missing content-length on 416 response");
+        throw new Error("Missing content-length on 416 response");
       }
       const actualLength = +contentRange.substr(8);
       resp = await fetch(this.url, {
@@ -457,7 +457,7 @@ export class FetchSource implements Source {
     }
 
     if (resp.status >= 300) {
-      throw Error(`Bad response code: ${resp.status}`);
+      throw new Error(`Bad response code: ${resp.status}`);
     }
 
     // some well-behaved backends, e.g. DigitalOcean CDN, respond with 200 instead of 206
@@ -465,7 +465,7 @@ export class FetchSource implements Source {
     const contentLength = resp.headers.get("Content-Length");
     if (resp.status === 200 && (!contentLength || +contentLength > length)) {
       if (controller) controller.abort();
-      throw Error(
+      throw new Error(
         "Server returned no content-length header or content-length exceeding request. Check that your storage backend supports HTTP Byte Serving."
       );
     }
@@ -494,7 +494,7 @@ export function bytesToHeader(bytes: ArrayBuffer, etag?: string): Header {
   const v = new DataView(bytes);
   const specVersion = v.getUint8(7);
   if (specVersion > 3) {
-    throw Error(
+    throw new Error(
       `Archive is spec version ${specVersion} but this library supports up to spec version 3`
     );
   }
@@ -966,7 +966,7 @@ export class PMTiles {
         return undefined;
       }
     }
-    throw Error("Maximum directory depth exceeded");
+    throw new Error("Maximum directory depth exceeded");
   }
 
   /**

js/test/v3.test.ts

@@ -42,7 +42,7 @@ class MockServer {
           this.numRequests++;
           const range = request.headers.get("range")?.substr(6).split("-");
           if (!range) {
-            throw Error("invalid range");
+            throw new Error("invalid range");
           }
           const offset = +range[0];
           const length = +range[1];

serverless/aws/src/index.ts

@@ -42,7 +42,7 @@ async function nativeDecompress(
   if (compression === Compression.Gzip) {
     return zlib.gunzipSync(buf);
   }
-  throw Error("Compression method not supported");
+  throw new Error("Compression method not supported");
 }
 
 // Lambda needs to run with 512MB, empty function takes about 70
@@ -90,7 +90,7 @@ class S3Source implements Source {
 
     const arr = await resp.Body?.transformToByteArray();
 
-    if (!arr) throw Error("Failed to read S3 response body");
+    if (!arr) throw new Error("Failed to read S3 response body");
 
     return {
       data: arr.buffer,

serverless/cloudflare/src/index.ts

@@ -36,7 +36,7 @@ async function nativeDecompress(
     const result = stream?.pipeThrough(new DecompressionStream("gzip"));
     return new Response(result).arrayBuffer();
   }
-  throw Error("Compression method not supported");
+  throw new Error("Compression method not supported");
 }
 
 const CACHE = new ResolvedValueCache(25, undefined, nativeDecompress);