From 4b2312c039d9e230c07738053bb31364a61927fe Mon Sep 17 00:00:00 2001
From: Brandon Liu <bdon@users.noreply.github.com>
Date: Fri, 16 May 2025 09:54:17 -0700
Subject: [PATCH] Iframe (#573)

* hash value for iframe

* app: modify UI for iframe mode

* change position of zoom number to not be blocked by large attribution
* improve appearance of filename in nav for local files

* improve fill appearance in overlay mode
---
 app/src/Frame.tsx   | 130 +++++++++++++++++++++++---------------------
 app/src/PageMap.tsx |  15 +++--
 2 files changed, 79 insertions(+), 66 deletions(-)

diff --git a/app/src/Frame.tsx b/app/src/Frame.tsx
index c1395ff..bc2befa 100644
--- a/app/src/Frame.tsx
+++ b/app/src/Frame.tsx
@@ -131,6 +131,7 @@ export function Frame(props: {
   children: JSX.Element;
   page: string;
   pmtilesOnly?: boolean;
+  iframe?: boolean;
 }) {
   const [errorMessage, setErrorMessage] = createSignal<string | undefined>();
   const [activeDrag, setActiveDrag] = createSignal<boolean>(false);
@@ -195,69 +196,76 @@ export function Frame(props: {
       ondragover={dragover}
       ondrop={drop}
     >
-      <div class="flex-none flex items-center px-4 md:px-0 pt-4 md:pt-0 flex-col md:flex-row">
-        <div class="flex items-center flex-grow flex-1">
-          <h1 class="hidden md:inline text-xl mx-5">{pageTitle}</h1>
-          <form class="flex flex-1 items-center" onSubmit={loadTileset}>
-            <span class="relative flex flex-1 items-center app-border">
-              <Show
-                when={
-                  props.tileset() &&
-                  props.tileset()?.getStateUrl() === undefined
-                }
-              >
-                <span class="bg-yellow-500 rounded px-2 text-sm text-black">
-                  local file {props.tileset()?.getLocalFileName()}
-                </span>
-              </Show>
-              <input
-                class="px-2 flex-1"
-                type="text"
-                name="url"
-                placeholder={`${props.pmtilesOnly ? "" : "TileJSON or "}.pmtiles`}
-                value={props.tileset()?.getStateUrl() || ""}
-              />
-              <Show when={props.tileset()}>
-                <button
-                  type="button"
-                  class="mr-2 text-sm px-2 btn-secondary cursor-pointer"
-                  onClick={() => props.setTileset(undefined)}
+      <Show when={!props.iframe}>
+        <div class="flex-none flex items-center px-4 md:px-0 pt-4 md:pt-0 flex-col md:flex-row">
+          <div class="flex items-center flex-grow flex-1">
+            <h1 class="hidden md:inline text-xl mx-5">{pageTitle}</h1>
+            <form class="flex flex-1 items-center" onSubmit={loadTileset}>
+              <span class="relative flex flex-1 items-center app-border">
+                <Show
+                  when={
+                    props.tileset() &&
+                    props.tileset()?.getStateUrl() === undefined
+                  }
+                  fallback={
+                    <input
+                      class="px-2 flex-1"
+                      type="text"
+                      name="url"
+                      placeholder={`${props.pmtilesOnly ? "" : "TileJSON or "}.pmtiles`}
+                      value={props.tileset()?.getStateUrl() || ""}
+                    />
+                  }
                 >
-                  clear
-                </button>
-              </Show>
-            </span>
-            <button class="px-4 ml-2 btn-primary cursor-pointer" type="submit">
-              load
-            </button>
-            <a
-              href="https://github.com/protomaps/PMTiles"
-              target="_blank"
-              rel="noreferrer"
-              class="hidden md:inline text-xs mx-4"
-            >
-              @{GIT_SHA}
-            </a>
-          </form>
+                  <span class="flex-1 app-well rounded px-2 m-1 text-sm">
+                    {props.tileset()?.getLocalFileName()}
+                  </span>
+                </Show>
+                <Show when={props.tileset()}>
+                  <button
+                    type="button"
+                    class="mr-2 text-sm px-2 btn-secondary cursor-pointer"
+                    onClick={() => props.setTileset(undefined)}
+                  >
+                    clear
+                  </button>
+                </Show>
+              </span>
+              <button
+                class="px-4 ml-2 btn-primary cursor-pointer"
+                type="submit"
+              >
+                load
+              </button>
+              <a
+                href="https://github.com/protomaps/PMTiles"
+                target="_blank"
+                rel="noreferrer"
+                class="hidden md:inline text-xs mx-4"
+              >
+                @{GIT_SHA}
+              </a>
+            </form>
+          </div>
+          <div class="flex">
+            <LinkTab
+              page="map"
+              selected={props.page === "map"}
+              tileset={props.tileset}
+            />
+            <LinkTab
+              page="archive"
+              selected={props.page === "archive"}
+              tileset={props.tileset}
+            />
+            <LinkTab
+              page="tile"
+              selected={props.page === "tile"}
+              tileset={props.tileset}
+            />
+          </div>
         </div>
-        <div class="flex">
-          <LinkTab
-            page="map"
-            selected={props.page === "map"}
-            tileset={props.tileset}
-          />
-          <LinkTab
-            page="archive"
-            selected={props.page === "archive"}
-            tileset={props.tileset}
-          />
-          <LinkTab
-            page="tile"
-            selected={props.page === "tile"}
-            tileset={props.tileset}
-          />
-        </div>
-      </div>
+      </Show>
       <Show when={errorMessage()}>
         <div class="bg-red-900 px-2 py-3 flex justify-between">
           <span>{errorMessage()}</span>
diff --git a/app/src/PageMap.tsx b/app/src/PageMap.tsx
index 705c665..6365c42 100644
--- a/app/src/PageMap.tsx
+++ b/app/src/PageMap.tsx
@@ -117,8 +117,12 @@ function MapView(props: {
       protocol.add(archiveForProtocol);
     }
 
+    let fillOpacity = 0.2;
+    let fillHighlightOpacity = 0.4;
     if (await tileset.isOverlay()) {
       setBasemap(true);
+      fillOpacity = 0.6;
+      fillHighlightOpacity = 0.8;
     }
 
     if (await tileset.isVector()) {
@@ -139,8 +143,8 @@ function MapView(props: {
             "fill-opacity": [
               "case",
               ["boolean", ["feature-state", "hover"], false],
-              0.25,
-              0.1,
+              fillHighlightOpacity,
+              fillOpacity,
             ],
           },
           filter: ["==", ["geometry-type"], "Polygon"],
@@ -522,10 +526,10 @@ function MapView(props: {
               setBasemap={setBasemap}
             />
           </div>
-          <div class="absolute left-2 bottom-2">
+          <div class="absolute left-3 top-28">
             <button
               type="button"
-              class="flex items-center rounded border app-bg app-border cursor-pointer"
+              class="flex items-center rounded app-border cursor-pointer"
               onClick={roundZoom}
             >
               <span class="app-well px-1 rounded-l">Z</span>
@@ -570,6 +574,7 @@ function PageMap() {
     });
     hash = parseHash(location.hash);
   }
+  const iframe = hash.iframe === "true";
 
   const mapHashPassed = hash.map !== undefined;
   const [tileset, setTileset] = createSignal<Tileset | undefined>(
@@ -597,7 +602,7 @@ function PageMap() {
   });
 
   return (
-    <Frame tileset={tileset} setTileset={setTileset} page="map">
+    <Frame tileset={tileset} setTileset={setTileset} page="map" iframe={iframe}>
       <Show
         when={tileset()}
         fallback={<ExampleChooser setTileset={setTileset} />}